ci: run extended tests on aggregate and window function changes - #24403
Open
shinzoxD wants to merge 1 commit into
Open
ci: run extended tests on aggregate and window function changes#24403shinzoxD wants to merge 1 commit into
shinzoxD wants to merge 1 commit into
Conversation
The PR path filter for extended.yml omitted functions-aggregate and functions-window, so PRs such as apache#24104 did not run aggregate_fuzz or window_fuzz before merge. Add both crates the fuzzers import. Fixes apache#24212
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24403 +/- ##
==========================================
- Coverage 81.18% 81.18% -0.01%
==========================================
Files 1110 1110
Lines 388906 388906
Branches 388906 388906
==========================================
- Hits 315733 315730 -3
- Misses 54576 54579 +3
Partials 18597 18597 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
for anyone looking at this PR please see my comment here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The
Datafusion extended testsworkflow is the only CI job that enablesextended_tests, which is what gatesaggregate_fuzzandwindow_fuzz. On pull requests the path filter did not include the two crates those fuzzers actually import:aggregate_fuzz.rsbuilds queries withmin/max/sum/count/median/first_value/last_valuefromdatafusion/functions-aggregatewindow_fuzz.rsimportsdatafusion_functions_windowanddatafusion_functions_aggregateA PR that only changes those crates (for example #24104, which updated
median.rs) therefore skipped the suite built to exercise it. The post-merge run onmainstill catches failures, but the cost is a redmaininstead of a red PR.#24212 measured this as a 4% extra trigger rate on recent PRs (~9.5 minutes wall-clock because the three jobs already run in parallel).
What changes are included in this PR?
Add the two path globs requested in #24212:
This is the small, two-line option from the issue. It does not widen the filter to
datasource*/catalog*(those would raise the trigger rate a lot more), and it does not split the path set per job.Are these changes tested?
This is a GitHub Actions path-filter change, so there is no unit test to run.
Verified:
yaml.safe_load)datafusion/functions-aggregate/anddatafusion/functions-window/exist and contain the implementations the fuzzers import*.rsstyle of the other extended-test path filtersAre there any user-facing changes?
No.