Skip to content

Enable remove_chunk_markers by default. Fix a bug and add a comment. - #830

Merged
deanberris merged 1 commit into
cpp-netlib:masterfrom
igorpeshansky:fix-remove-chunk-markers
Mar 15, 2018
Merged

Enable remove_chunk_markers by default. Fix a bug and add a comment.#830
deanberris merged 1 commit into
cpp-netlib:masterfrom
igorpeshansky:fix-remove-chunk-markers

Conversation

@igorpeshansky

Copy link
Copy Markdown

No description provided.

@igorpeshansky

Copy link
Copy Markdown
Author

@deanberris PTAL.
@umennel FYI.

@deanberris deanberris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deanberris
deanberris merged commit 540ed76 into cpp-netlib:master Mar 15, 2018
@deanberris

Copy link
Copy Markdown
Member

Thanks, @igorpeshansky -- would it make sense if you merge these into 0.13-release as well? It may not be a straight-forward merge.

@igorpeshansky

Copy link
Copy Markdown
Author

@deanberris Did you mean both #720 and #830?

@deanberris

Copy link
Copy Markdown
Member

@igorpeshansky Yes, both those would be good to see in 0.13-release.

@umennel

umennel commented Mar 31, 2018

Copy link
Copy Markdown

Cherry-picked commits from both PRs with #833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants