fix(typebox): support nested extension query keys - #3697
Open
tonycoder-hub wants to merge 1 commit into
Open
Conversation
tonycoder-hub
force-pushed
the
fix/typebox-query-syntax-extension-sort
branch
from
August 13, 2026 12:12
608f7a4 to
c028e7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
querySyntaxcurrently accepts nested extension fields for property queries, but$sortand$selectonly expose top-level schema keys. As a result, valid nested extension keys such asprofile.nameare rejected. This change derives sortable/selectable nested keys from non-operator extension entries while continuing to exclude$-prefixed query operators.Fixes #3526.
No.
Verification
npm run mocha --workspace @feathersjs/typebox(10 passing)tsc -p packages/typebox/tsconfig.json --noEmitgit diff --checkOther Information
The implementation and review used AI assistance. The final diff, regression behavior, type checks, and test results were independently verified before submission.