fix: show error details in preset catalog config read failure - #3840
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves preset catalog removal errors by displaying the underlying configuration-read exception.
Changes:
- Captures and prints configuration read failure details.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/presets/_commands.py |
Adds exception details to catalog removal errors. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Medium
Capture and display the exception message when reading preset-catalogs.yml fails, instead of swallowing the error details. Matches the pattern used in preset_catalog_add 54 lines earlier.
Quratulain-bilal
force-pushed
the
fix/presets-show-error
branch
from
July 30, 2026 15:39
7ba534e to
1fe7b04
Compare
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (1)
src/specify_cli/presets/_commands.py:769
- Escape the exception text before passing it to Rich. YAML parser errors can echo the invalid source line; if that line contains an unmatched tag such as
[/red],console.printraisesMarkupErrorhere and the command shows a traceback instead of the intended read error. The equivalent add path already escapesstr(e)at lines 708–710.
console.print(f"[red]Error:[/red] Failed to read preset catalog config: {e}")
- Files reviewed: 1/1 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Capture and display exception message when reading preset-catalogs.yml fails.
Changes
_commands.py: Addedas eto except clause and display error details