Skip to content

Improve GIDSignIn addScopes implementation - #68

Merged
Alex-4-Git merged 1 commit into
mainfrom
pin-refactor-addScopes
Dec 6, 2021
Merged

Improve GIDSignIn addScopes implementation#68
Alex-4-Git merged 1 commit into
mainfrom
pin-refactor-addScopes

Conversation

@Alex-4-Git

Copy link
Copy Markdown
Contributor

Update the current user's scopes instead of creating a new user when adding new scopes.

@Alex-4-Git
Alex-4-Git requested review from ch40w31 and petea November 5, 2021 21:47
@Alex-4-Git
Alex-4-Git force-pushed the pin-refactor-addScopes branch from 32c11d2 to 7e4f0c9 Compare November 9, 2021 19:57
@petea petea added this to the 6.1.0 milestone Nov 10, 2021
Comment thread GoogleSignIn/Sources/GIDGoogleUser.m Outdated
@Alex-4-Git
Alex-4-Git force-pushed the pin-refactor-addScopes branch 2 times, most recently from dbcbd05 to 4462f14 Compare November 19, 2021 01:28
Comment thread GoogleSignIn/Sources/GIDGoogleUser_Private.h Outdated
Comment thread GoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment thread GoogleSignIn/Sources/GIDGoogleUser_Private.h Outdated
Comment thread GoogleSignIn/Sources/GIDSignIn.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
@Alex-4-Git
Alex-4-Git force-pushed the pin-refactor-addScopes branch 2 times, most recently from ac72193 to 5eccd2c Compare November 22, 2021 23:28
Comment thread GoogleSignIn/Sources/GIDScopes.m Outdated
@Alex-4-Git
Alex-4-Git force-pushed the pin-refactor-addScopes branch from c1bf3f8 to 4da8a67 Compare November 23, 2021 23:27
Comment thread GoogleSignIn/Sources/GIDScopes.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
Comment thread GoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment thread GoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment thread GoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment thread GoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment thread GoogleSignIn/Sources/GIDScopes.m Outdated
@Alex-4-Git
Alex-4-Git requested a review from petea December 2, 2021 16:50
Comment thread GoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment thread GoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment thread GoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment thread GoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment thread GoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment thread GoogleSignIn/Sources/GIDGoogleUser.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m

@petea petea left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to do some manual testing of key flows while keeping an eye on GIDGoogleUser property values as a sanity check before merging.

When you're ready to merge, please use the "Squash and merge" option.

Comment thread GoogleSignIn/Sources/GIDSignInInternalOptions.h Outdated
Comment thread GoogleSignIn/Sources/GIDSignInInternalOptions.h Outdated
Comment thread GoogleSignIn/Sources/GIDSignInInternalOptions.h Outdated
@Alex-4-Git
Alex-4-Git force-pushed the pin-refactor-addScopes branch from fda7657 to 4099db2 Compare December 6, 2021 17:33
@Alex-4-Git
Alex-4-Git requested a review from petea December 6, 2021 18:27
@Alex-4-Git
Alex-4-Git merged commit 74b7d7f into main Dec 6, 2021
@Alex-4-Git
Alex-4-Git deleted the pin-refactor-addScopes branch February 1, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants