Set include_granted_scopes=true in the auth request - #70
Merged
Conversation
mdmathias
requested changes
Nov 10, 2021
mdmathias
left a comment
Collaborator
There was a problem hiding this comment.
Could we add a test to GIDSignInTest.m to ensure that the additionalParameters passed to -[OIDAuthorizationRequest initWithConfiguration:clientId:scopes:redirectURL:responseType:additionalParameters:] is correct? It'd be nice to document in test the expectations we have for this.
petea
force-pushed
the
petea-include-granted-scopes
branch
from
November 16, 2021 19:02
e933779 to
964b9d8
Compare
Contributor
Author
Added a check for the static include_granted_scopes value. The other additionalParameters values are dynamic and get checked in specific tests. |
mdmathias
approved these changes
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to restore a user's previously granted scopes at sign-in time, we'll want to start using include_granted_scopes=true in the auth request.