Skip to content

Uniform variable syntax - #686

Closed
nikic wants to merge 33 commits into
php:phpngfrom
nikic:uniformVariableSyntax
Closed

Uniform variable syntax#686
nikic wants to merge 33 commits into
php:phpngfrom
nikic:uniformVariableSyntax

Conversation

@nikic

@nikic nikic commented Jun 6, 2014

Copy link
Copy Markdown
Member

nikic added 30 commits May 30, 2014 16:31
@nikic
Change precedence of $ operator
95a3a12 
$$foo['bar'] is now interpreted as ${$foo}['bar'] rather than
${$foo['bar']}.
@nikic
Temporarily disable complex variables in new expressions
e2be2ce
@nikic
Get rid of base_variable_with_function_calls
46e35e3
@nikic
Use recursion for property fetches
b8b3b35
@nikic
LTR static member access
a8c1595
@nikic
Recursive definition for object proprety fetches
667f840
@nikic
Make function calls directly callable
e89958a
@nikic
Remove reference_variable indirection
067fca0
@nikic
Reintroduce new expression dereferencing
295d07e
@nikic
Cleanup old grammar rules
87f8e75
@nikic
Minor cleanup
5712f0e
@nikic
Generalize expression dereferencing
46a2ca8
@nikic
Integrate combined scalar as dereferencable
75c0db1
@nikic
Allow arrays + object access for new expressions
ff475e9
@nikic
Update two tests with new semantics
c5920af
@nikic
Update another test
c29d3b6
@nikic
Remove object_stack (mostly)
fcf42d8
@nikic
Remove now unnecessary code in begin_method_call
8a65c3b
@nikic
Generalize static access syntax
f48241f
@nikic
Add two initial tests
4ec505f
@nikic
Introduce dereferencable_scalar to simplify future additions
64f80b3
@nikic
Fix previous commit
fd85f77
@nikic
Support directly calling closure
64e4c9e
@nikic
Property handle calls on [] and '' consts/tmps
c53a7ea
@nikic
Properly handle property read on const/tmp
f0ac7f7
@nikic
Add another static member access test
72b5e0c
@nikic
Forbid writing to temporary expressions
5c2120b
@nikic
Support isset() on temporaries
96b32ec
@nikic
Handle FUNC_ARG fetches on temporaries
8515b96
@nikic
Remove duplication
8d7f5a4
@Tyrael

Tyrael commented Jun 6, 2014

Copy link
Copy Markdown
Contributor

awesome!

@JanTvrdik

JanTvrdik commented Jun 8, 2014

Copy link
Copy Markdown

👍

1 similar comment
@hrach

hrach commented Jun 8, 2014

Copy link
Copy Markdown

👍

@smalyshev

smalyshev commented Jun 8, 2014

Copy link
Copy Markdown
Contributor

I like it. 👍

@brandonwamboldt

brandonwamboldt commented Jun 9, 2014

Copy link
Copy Markdown

👍 Would love to have these changes

@rquadling

rquadling commented Jun 9, 2014

Copy link
Copy Markdown
Contributor

Brilliant work. Very very impressed. Is there a way to determine how much
(if any) actual uses of the incompatible usages there are in common
apps/libraries? I suppose that is EXACTLY why unit testing exists, but as
well all know, not everything is.

But that aside, the RFC is very clear and understandable.

On 9 June 2014 16:08, Brandon Wamboldt notifications@github.com wrote:

[image: 👍] Would love to have these changes

—
Reply to this email directly or view it on GitHub
#686 (comment).

Richard Quadling
Twitter : @rquadling
EE : http://e-e.com/M_248814.html
Zend : http://bit.ly/9O8vFY

@Tyrael

Tyrael commented Jun 9, 2014

Copy link
Copy Markdown
Contributor

@rquadling the RFC mentions testing two mainstream php framework (ZF and Symfony, would be nice showing the exact version numbers tested) but ofc. running more userland unittests agains phpng and this particular PR would be helpful for indentifying the severity of the BC breaks.

@echochamber

echochamber commented Jun 9, 2014

Copy link
Copy Markdown

👍

3 similar comments
@hfern

hfern commented Jun 10, 2014

Copy link
Copy Markdown

👍

@maroon775

maroon775 commented Jun 17, 2014

Copy link
Copy Markdown

👍

@KonstantinKuklin

KonstantinKuklin commented Jun 21, 2014

Copy link
Copy Markdown

👍

@igor822

igor822 commented Jun 22, 2014

Copy link
Copy Markdown

Yess

@Hywan

Hywan commented Jul 7, 2014

Copy link
Copy Markdown
Contributor

👍

@php-pulls

php-pulls commented Aug 26, 2014

Copy link
Copy Markdown

Comment on behalf of nikic at php.net:

Closing, as this has been merged.

@php-pulls php-pulls closed this Aug 26, 2014
@mbrevda mbrevda mentioned this pull request Dec 23, 2014
Closed
@jwatzman jwatzman mentioned this pull request Aug 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.