Use initial root-locus limits when choosing gains - #1233
Open
marko1olo wants to merge 1 commit into
Open
Conversation
Author
|
Local verification on
GitHub currently shows this as pending/unstable without any check runs or commit statuses attached to the head SHA, so I do not see a failing job to address from the API side. |
Member
|
@marko1olo Please rebase off of main to trigger updated CI checks from PR #1243. |
|
coverage: 94.757%. remained the same — marko1olo:fix-root-locus-grid-margins into python-control:main |
Author
|
Rebased on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xlimandylimfromroot_locus_plot()into the initialroot_locus_map()call.root_locus_map(..., xlim=..., ylim=...).Tests
MPLBACKEND=Agg python -m pytest control/tests/rlocus_test.py::test_root_locus_plot_initial_limits_refine_gains -qMPLBACKEND=Agg python -m pytest control/tests/rlocus_test.py -qpython -m ruff check --no-cache control/rlocus.py control/tests/rlocus_test.pypython -m compileall -q control/rlocus.py control/tests/rlocus_test.pyAI Disclosure: Claude Code (Opus 5) was used during code navigation, initial drafting, and PR text preparation. All logic, code changes, and test cases have been manually reviewed, verified, and tested locally by the author in accordance with the NumPy AI Policy.