Skip to content

deps: Update mozjs_sys to v140.11 - #45584

Merged
jschwe merged 2 commits into
servo:mainfrom
jschwe:update_mozjs
Jun 13, 2026
Merged

deps: Update mozjs_sys to v140.11#45584
jschwe merged 2 commits into
servo:mainfrom
jschwe:update_mozjs

Conversation

@jschwe

@jschwe jschwe commented Jun 11, 2026

Copy link
Copy Markdown
Member

Regular mozjs update with latest ESR security fixes.

Testing: Covered by normal tests.

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 11, 2026
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Jun 11, 2026
@Gae24
Gae24 added this pull request to the merge queue Jun 11, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 11, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 11, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jun 11, 2026
@jdm

jdm commented Jun 12, 2026

Copy link
Copy Markdown
Member

Windows linker reports undefined symbols :(

@jschwe

jschwe commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

The good news is that $env:MOZJS_FROM_SOURCE=1 fixes the link. The bad news is that we need to figure out in how far the mozjs CI mismatches with ours that causes this ABI (?) issue. Maybe time to prioritize my shared library branch again?

@jschwe

jschwe commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

Most likely it's that windows-latest / windows-2025 has changed to visual studio 2026 in june: actions/runner-images#14017

So either we upgrade our ci-runners to the same windows version, or we downgrade mozjs CI.

@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-tests-failed The changes caused existing tests to fail. labels Jun 12, 2026
jschwe added 2 commits June 12, 2026 17:54
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
@jschwe

jschwe commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

try run (windows) succeeded: https://github.com/servo/servo/actions/runs/27427021664/job/81070192339

Might be worth thinking about if similar issues could also happen with ubuntu-latest / macos-latest if the default toolchains change.

@jdm
jdm added this pull request to the merge queue Jun 12, 2026
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 12, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 12, 2026
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Jun 12, 2026
@jschwe
jschwe added this pull request to the merge queue Jun 13, 2026
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Jun 13, 2026
Merged via the queue into servo:main with commit 4f55165 Jun 13, 2026
37 checks passed
@jschwe
jschwe deleted the update_mozjs branch June 13, 2026 06:56
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-review There is new code that needs to be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants