GSI macOS support preparation - #102
Merged
Merged
Conversation
Alex-4-Git
commented
Feb 26, 2022
Contributor
- Edit Cocoapods and Swift Package manager config file.
- Annotate iOS specific components.
Alex-4-Git
force-pushed
the
pin-macOSSupport
branch
2 times, most recently
from
February 26, 2022 02:05
71a44d3 to
deba5dc
Compare
mdmathias
approved these changes
Mar 8, 2022
mdmathias
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. I do suggest using #import if there is no reason to use #include.
petea
suggested changes
Mar 8, 2022
ch40w31
reviewed
Mar 8, 2022
Contributor
Author
|
Close this PR since we can only exclude the header when they are not used. |
Alex-4-Git
force-pushed
the
pin-macOSSupport
branch
from
March 9, 2022 00:50
deba5dc to
dec40bf
Compare
Alex-4-Git
force-pushed
the
pin-macOSSupport
branch
from
March 9, 2022 00:54
dec40bf to
39cfcec
Compare
mdmathias
self-requested a review
March 9, 2022 01:08
petea
approved these changes
Mar 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.