Skip to content

Add macOS support including API changes, implementations and unit tests. - #104

Merged
Alex-4-Git merged 19 commits into
mainfrom
pin-macOSImplementation
Mar 23, 2022
Merged

Add macOS support including API changes, implementations and unit tests.#104
Alex-4-Git merged 19 commits into
mainfrom
pin-macOSImplementation

Conversation

@Alex-4-Git

@Alex-4-Git Alex-4-Git commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

This is a chained PR on top of the PR GSI macOS support preparation.
(#102)

@Alex-4-Git
Add macOS support in configuration
202cd5f 
Edit SPM and cocoapods configuration file to support macOS.
@Alex-4-Git
Alex-4-Git requested review from mdmathias and petea March 1, 2022 23:07
@Alex-4-Git
Alex-4-Git changed the base branch from pin-macOSSupport to main March 8, 2022 22:56
@Alex-4-Git
Alex-4-Git force-pushed the pin-macOSImplementation branch from ece1000 to 128b568 Compare March 8, 2022 23:05
mdmathias
mdmathias requested changes Mar 9, 2022
View reviewed changes
Comment thread GoogleSignIn/Sources/GIDAuthentication.m
Comment thread GoogleSignIn/Sources/GIDSignIn.m Outdated
@Alex-4-Git
Alex-4-Git changed the base branch from main to pin-macOSSupport March 9, 2022 00:56
@Alex-4-Git
Alex-4-Git force-pushed the pin-macOSImplementation branch 3 times, most recently from 1354ce5 to 7fc8937 Compare March 9, 2022 01:52
Alex-4-Git and others added 2 commits March 8, 2022 17:54
@Alex-4-Git
Automate build and test on macOS.
623ffa7
@AntonKozlovskyi @petea @Alex-4-Git
Add the option to choose additional scopes at sign-in (#30)
b2a77a3 
* fix calling callback on addScopes

* Add possibility to choose scopes in time of sign in

* fixes due review

* Complete merge from main

Co-authored-by: Peter Andrews <petea@google.com>
@Alex-4-Git
Alex-4-Git force-pushed the pin-macOSImplementation branch from 7fc8937 to b2a77a3 Compare March 9, 2022 01:54
@petea petea added this to the 6.2.0 milestone Mar 9, 2022
petea
petea reviewed Mar 15, 2022
View reviewed changes
Comment thread .github/workflows/tests.yml Outdated
Comment thread .github/workflows/tests.yml Outdated
Comment thread GoogleSignIn/Sources/GIDAuthentication.m
@Alex-4-Git
Alex-4-Git changed the base branch from pin-macOSSupport to main March 16, 2022 00:05
@Alex-4-Git
Alex-4-Git force-pushed the pin-macOSImplementation branch 2 times, most recently from 8c6d9e8 to d39ab3a Compare March 16, 2022 01:17
mdmathias and others added 2 commits March 15, 2022 18:28
@mdmathias @Alex-4-Git
Import GTMFetcherAuthorizationProtocol in GIDAuthentication to expose…
49c84f7 
… to Swift (#107)

Forward declaring the protocol in GIDAuthentication led to a method vending a
GTMFetcherAuthorizationProtocol conforming instance to not be visible in Swift.

Fixes #106.
@Alex-4-Git
Exclude GIDSignInbutton from macOS.
e3f7bcf
@Alex-4-Git
Alex-4-Git force-pushed the pin-macOSImplementation branch from 94d6d52 to e3f7bcf Compare March 16, 2022 01:36
@Alex-4-Git
Alex-4-Git force-pushed the pin-macOSImplementation branch from 996c117 to 11fb1ce Compare March 16, 2022 02:13
@Alex-4-Git
Alex-4-Git force-pushed the pin-macOSImplementation branch 2 times, most recently from d7474f3 to 59d61b6 Compare March 16, 2022 22:07
@petea

petea commented Mar 21, 2022

Copy link
Copy Markdown
Contributor

The pod lib lint tests are now completing but failing on warnings. You should be able to resolve them.

petea
petea suggested changes Mar 21, 2022
View reviewed changes
Comment thread GoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
Comment thread GoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
Comment thread GoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h
Comment thread GoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
Comment thread GoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
Comment thread GoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
Comment thread GoogleSignIn/Sources/Public/GoogleSignIn/GIDSignIn.h Outdated
Comment thread GoogleSignIn/Sources/Public/GoogleSignIn/GIDSignInButton.h Outdated
Comment thread GoogleSignIn/Sources/Public/GoogleSignIn/GoogleSignIn.h Outdated
Comment thread GoogleSignIn/Sources/GIDAuthentication.m Outdated
petea
petea reviewed Mar 21, 2022
View reviewed changes
Comment thread .github/workflows/tests.yml Outdated
petea
petea reviewed Mar 21, 2022
View reviewed changes
Comment thread .github/workflows/tests.yml Outdated
@Alex-4-Git
Alex-4-Git force-pushed the pin-macOSImplementation branch from 990a879 to fde63c2 Compare March 21, 2022 21:40
petea
petea reviewed Mar 21, 2022
View reviewed changes
Comment thread GoogleSignIn.podspec Outdated
@Alex-4-Git
Alex-4-Git force-pushed the pin-macOSImplementation branch from fde63c2 to c3d5ec5 Compare March 22, 2022 01:29
@Alex-4-Git
Alex-4-Git force-pushed the pin-macOSImplementation branch from c3d5ec5 to 9c9bfdf Compare March 22, 2022 15:19
petea
petea suggested changes Mar 22, 2022
View reviewed changes
Comment thread GoogleSignIn/Tests/Unit/GIDAuthenticationTest.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDConfigurationTest.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDGoogleUserTest.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDProfileDataTest.m Outdated
petea
petea reviewed Mar 22, 2022
View reviewed changes
Comment thread GoogleSignIn/Sources/GIDSignIn.m Outdated
petea
petea reviewed Mar 22, 2022
View reviewed changes
Comment thread GoogleSignIn/Sources/GIDSignInButton.m Outdated
petea
petea reviewed Mar 22, 2022
View reviewed changes
Comment thread GoogleSignIn/Tests/Unit/GIDEMMErrorHandlerTest.m Outdated
petea
petea reviewed Mar 22, 2022
View reviewed changes
Comment thread GoogleSignIn/Tests/Unit/GIDMDMPasscodeStateTests.m Outdated
petea
petea reviewed Mar 22, 2022
View reviewed changes
Comment thread GoogleSignIn/Tests/Unit/GIDSignInButtonTest.m Outdated
@Alex-4-Git
Alex-4-Git requested review from mdmathias and petea March 23, 2022 00:18
petea
petea suggested changes Mar 23, 2022
View reviewed changes
Comment thread GoogleSignIn/Sources/GIDAuthentication_Private.h Outdated
Comment thread GoogleSignIn/Sources/GIDAuthentication_Private.h Outdated
Comment thread GoogleSignIn/Sources/GIDSignIn.m
Comment thread GoogleSignIn/Sources/GIDSignIn.m Outdated
Comment thread GoogleSignIn/Sources/GIDSignIn.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m
Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m
Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m
Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
@Alex-4-Git
Alex-4-Git requested a review from petea March 23, 2022 21:39
@Alex-4-Git
Alex-4-Git force-pushed the pin-macOSImplementation branch from ae02ecc to fa19f96 Compare March 23, 2022 21:49
Alex-4-Git
Alex-4-Git commented Mar 23, 2022
View reviewed changes

@Alex-4-Git Alex-4-Git left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finish my reivew

Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m
Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m
Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m
Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m
Comment thread GoogleSignIn/Tests/Unit/GIDAuthenticationTest.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDAuthenticationTest.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDProfileDataTest.m
Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
Comment thread GoogleSignIn/Tests/Unit/GIDSignInTest.m Outdated
@Alex-4-Git
Alex-4-Git merged commit 61e8b8a into main Mar 23, 2022
@Alex-4-Git
Alex-4-Git deleted the pin-macOSImplementation branch May 25, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdmathias mdmathias mdmathias approved these changes
+1 more reviewer
@petea petea petea approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

6.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Alex-4-Git @petea @mdmathias @AntonKozlovskyi