Fix time_response_plot for response lists - #1224
Closed
marko1olo wants to merge 1 commit into
Closed
Conversation
Member
|
@marko1olo Please rebase off of main to trigger updated CI checks from PR #1243. |
|
coverage: 94.742% (-0.02%) from 94.757% — marko1olo:fix-time-response-list-plot into python-control:main |
Route TimeResponseList and plain lists of time responses through the existing TimeResponseList plotting path when calling the public time_response_plot function directly. This keeps response_list.plot() behavior unchanged while fixing the standalone function for list-returning simulation calls.
Author
|
Closing this in favor of #1231 which has the clean rebased branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1171.
step_response([sys1, sys2])and related simulation calls returnTimeResponseList. Calling.plot()on that object already worked, but calling the public function directly raised before it could plot:This routes
TimeResponseListand plain Python lists of time responses through the existingTimeResponseList.plot()path. The change is scoped to the crash/list-support part of the issue and leaves the color-improvement discussion separate.Local validation:
ct.time_response_plot(ct.step_response([sys1, sys2]))raisedAttributeError: 'TimeResponseList' object has no attribute 'plot_inputs'.(1, 1)plot with two lines for SISO responses.MPLBACKEND=Agg PYTHONPATH=. python -m pytest control\tests\timeplot_test.py::test_list_responses -q-> 5 passedMPLBACKEND=Agg PYTHONPATH=. python -m pytest control\tests\timeplot_test.py -q-> 73 passed, 3 skippedpython -m ruff check control\timeplot.py control\tests\timeplot_test.pypython -m compileall -q control\timeplot.py control\tests\timeplot_test.pygit diff --checkAuthored with assistance from OpenAI Codex.
AI Disclosure: Codex (ChatGPT 5.5) was used during code navigation, initial drafting, and PR text preparation. All logic, code changes, and test cases have been manually reviewed, verified, and tested locally by the author in accordance with the NumPy AI Policy.