Fix time_response_plot for response lists - #1231
Conversation
|
Local verification on The only local warning was pytest being unable to write |
|
@marko1olo Please rebase off of main to trigger updated CI checks from PR #1243. |
|
coverage: 94.777% (+0.02%) from 94.757% — marko1olo:fix-time-response-plot-list into python-control:main |
|
Rebased on |
|
@marko1olo What is the relationship between this PR and #1224, which has the same title (verbatim) and also claims to fix #1171 ? |
|
@slivingston My bad on the confusion — #1224 was an earlier branch that had merge conflicts. I pushed the clean rebased commit here in #1231 and just closed #1224 so we can track the fix cleanly in one place. |
|
@marko1olo Please be more careful before you submit PRs... Though you give the reason that #1224 had a "merge conflict," it was opened only 2 days before this PR, and you kept both open for a long time and handled #1224 as if it still deserved review (e.g., when Richard asked for it to be rebased a few days ago, you rebased it). |
Summary
Fixes
time_response_plot()when called directly with a list ofTimeResponseDataobjects, as shown in #1171.The function now combines response lists into a multi-trace response before calculating plot layout, so callers do not hit
AttributeErroron list attributes such asplot_inputsorninputs.Checks
ct.time_response_plot([resp1, resp2])failed withAttributeError: 'list' object has no attribute 'plot_inputs'.ct.time_response_plot([resp1, resp2], plot_inputs=True)failed withAttributeError: 'list' object has no attribute 'ninputs'.MPLBACKEND=Agg python -m pytest control/tests/timeplot_test.py::test_time_response_plot_response_list control/tests/timeplot_test.py::test_list_responses -qpassed: 6 passed.MPLBACKEND=Agg python -m pytest control/tests/timeplot_test.py -qpassed: 74 passed, 3 skipped.MPLBACKEND=Agg python -m pytest control/tests/timeresp_test.py control/tests/trdata_test.py -qpassed: 276 passed, 46 skipped.python -m ruff check control/timeplot.py control/tests/timeplot_test.pypassed.python -m compileall -q control/timeplot.py control/tests/timeplot_test.pypassed.git diff --check HEAD~1..HEADpassed.AI Disclosure: Claude Code (Opus 5) was used during code navigation, initial drafting, and PR text preparation. All logic, code changes, and test cases have been manually reviewed, verified, and tested locally by the author in accordance with the NumPy AI Policy.